✨ [maykinmedia/commonground-api-common#142] Use exception handler registry from commonground-api-common #723

OlhaZahoruiko · 2026-01-26T09:49:08Z

Fixes maykinmedia/commonground-api-common#142

Changes

[Describe the changes here]

codecov-commenter · 2026-01-26T09:51:26Z

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.92%. Comparing base (ff5f242) to head (270fa43).

Files with missing lines	Patch %	Lines
src/objects/utils/views.py	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   84.98%   84.92%   -0.06%     
==========================================
  Files         141      141              
  Lines        2843     2832      -11     
  Branches      224      222       -2     
==========================================
- Hits         2416     2405      -11     
  Misses        375      375              
  Partials       52       52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-26T09:56:25Z

Bencher Report

Branch	feature/142-custom-exception-handlers
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type	📈 view plot 🚷 view threshold	125.32 ms (+0.14%) Baseline: 125.13 ms	131.39 ms (95.38%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result	📈 view plot 🚷 view threshold	23.66 ms (+1.14%) Baseline: 23.39 ms	24.56 ms (96.32%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	📈 view plot 🚷 view threshold	312.56 ms (+1.30%) Baseline: 308.54 ms	323.97 ms (96.48%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5	📈 view plot 🚷 view threshold	307.91 ms (-0.35%) Baseline: 309.00 ms	324.45 ms (94.90%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20	📈 view plot 🚷 view threshold	133.96 ms (-0.18%) Baseline: 134.21 ms	140.92 ms (95.06%)

🐰 View full continuous benchmarking report in Bencher

danielmursa-dev · 2026-01-30T10:29:34Z

src/objects/tests/v2/test_filters.py

        response = self.client.get(self.url, {"type": objecttype_url})

        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+


Now, since the response is consistent with other projects, with invalid_params, etc., you can use this method to get the errors from vng_api_common.tests import get_validation_errors.

You can apply this for all tests as well.

danielmursa-dev · 2026-01-30T10:29:38Z

src/objects/tests/v2/test_filters.py

+        invalid_params = {p["name"]: p["reason"] for p in data["invalid_params"]}
+
        self.assertEqual(
-            response.json()["type"],
-            [
-                f"Select a valid object type. {objecttype_url} is not one of the available choices."
-            ],
+            invalid_params["type"],
+            f"Select a valid object type. {objecttype_url} is not one of the available choices.",


Suggested change

invalid_params = {p["name"]: p["reason"] for p in data["invalid_params"]}

self.assertEqual(

response.json()["type"],

[

f"Select a valid object type. {objecttype_url} is not one of the available choices."

],

invalid_params["type"],

f"Select a valid object type. {objecttype_url} is not one of the available choices.",

self.assertEqual(

get_validation_errors(response, "type"),

{

"name": "type",

"code": "invalid_choice",

"reason": f"Select a valid object type. {objecttype_url} is not one of the available choices.",

},

)

danielmursa-dev

Good 👍

requirements/base.in

stevenbal

Remarks about tests, looks good otherwise

src/objects/tests/utils.py

src/objects/utils/tests/test_exception_handler.py

src/objects/tests/v2/test_filters.py

src/objects/tests/v2/test_ordering.py

src/objects/tests/v2/test_validation.py

github-actions · 2026-02-10T15:33:54Z

Bencher Report

Branch	feature/142-custom-exception-handlers
Testbed	ubuntu-24.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type	📈 view plot 🚷 view threshold	110.73 ms (-9.64%) Baseline: 122.54 ms	128.67 ms (86.06%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result	📈 view plot 🚷 view threshold	22.02 ms (+2.41%) Baseline: 21.50 ms	22.58 ms (97.53%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	📈 view plot 🚷 view threshold	269.15 ms (-9.19%) Baseline: 296.38 ms	311.20 ms (86.49%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5	📈 view plot 🚷 view threshold	270.35 ms (-8.64%) Baseline: 295.92 ms	310.71 ms (87.01%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20	📈 view plot 🚷 view threshold	125.10 ms (-2.80%) Baseline: 128.71 ms	135.14 ms (92.57%)

🐰 View full continuous benchmarking report in Bencher

danielmursa-dev · 2026-02-11T08:42:23Z

src/objects/tests/v2/test_filters.py

+
+        data = response.json()
+
+        invalid_params = {p["name"]: p for p in data["invalid_params"]}


Suggested change

invalid_params = {p["name"]: p for p in data["invalid_params"]}

error = get_validation_errors(response, "type")

danielmursa-dev · 2026-02-11T08:50:13Z

src/objects/tests/v2/test_filters.py

        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+
+        data = response.json()
+        invalid_params = {p["name"]: p["reason"] for p in data["invalid_params"]}


@OlhaZahoruiko I think you can use this method everywhere to get the error dict

@stevenbal should we also add the key for validations that are not provided? like here

objects-api/src/objects/api/validators.py

Line 93 in ff5f242

raise serializers.ValidationError(message, code=code)

Suggested change

invalid_params = {p["name"]: p["reason"] for p in data["invalid_params"]}

error = get_validation_errors(response, "")

danielmursa-dev · 2026-02-12T12:53:15Z

src/objects/tests/v2/test_auth_fields.py

-            ["Fields in the configured authorization are absent in the data: 'some'"],
+        data = response.json()
+
+        reasons = [p["reason"] for p in data["invalid_params"]]


Also here:

Suggested change

reasons = [p["reason"] for p in data["invalid_params"]]

error = get_validation_errors(response, "")

danielmursa-dev · 2026-02-12T12:55:36Z

src/objects/tests/v2/test_auth_fields.py

+
+        data = response.json()
+
        self.assertEqual(


Suggested change

self.assertEqual(

error = get_validation_errors(response, "")

self.assertEqual(error["reason"]

I think you forget this one

danielmursa-dev · 2026-02-12T12:56:28Z

src/objects/tests/v2/test_filters.py

-            response.json(), ["Operator `lt` supports only dates and/or numeric values"]
+
+        data = response.json()
+        reasons = [p["reason"] for p in data["invalid_params"]]


Suggested change

reasons = [p["reason"] for p in data["invalid_params"]]

error = get_validation_errors(response, "")

danielmursa-dev · 2026-02-12T12:56:54Z

src/objects/tests/v2/test_filters.py

+
+        data = response.json()
+
+        self.assertEqual(


Suggested change

self.assertEqual(

error = get_validation_errors(response, "")

self.assertEqual(

danielmursa-dev · 2026-02-12T12:57:25Z

src/objects/tests/v2/test_filters.py

-            [
-                "'date' and 'registrationDate' parameters can't be used in the same request"
-            ],
+            data["invalid_params"][0]["reason"],


Suggested change

data["invalid_params"][0]["reason"],

error = get_validation_errors(response, "")

data["invalid_params"][0]["reason"],

And also here

danielmursa-dev · 2026-02-12T13:00:02Z

src/objects/tests/v2/test_object_api.py

+        self.assertEqual(
+            data["invalid_params"][0]["name"],
+            "date",
+        )
+        self.assertEqual(
+            data["invalid_params"][0]["reason"],
+            "Enter a valid date.",
+        )


Suggested change

self.assertEqual(

data["invalid_params"][0]["name"],

"date",

)

self.assertEqual(

data["invalid_params"][0]["reason"],

"Enter a valid date.",

)

error = get_validation_errors(response, "date")

danielmursa-dev · 2026-02-12T13:00:25Z

src/objects/tests/v2/test_object_api.py

+        self.assertEqual(
+            data["invalid_params"][0]["name"],
+            "registrationDate",
+        )
+        self.assertEqual(
+            data["invalid_params"][0]["reason"],
+            "Enter a valid date.",
+        )


Suggested change

self.assertEqual(

data["invalid_params"][0]["name"],

"registrationDate",

)

self.assertEqual(

data["invalid_params"][0]["reason"],

"Enter a valid date.",

)

error = get_validation_errors(response, "registrationDate")

danielmursa-dev · 2026-02-12T13:01:11Z

src/objects/tests/v2/test_object_api_fields.py

-            [
-                "'fields' query parameter has invalid or unauthorized values: 'someField'"
-            ],
+            data["invalid_params"][0]["reason"],


Suggested change

data["invalid_params"][0]["reason"],

error = get_validation_errors(response, "")

data["invalid_params"][0]["reason"],

danielmursa-dev · 2026-02-12T14:02:49Z

src/objects/tests/v2/test_filters.py

+
+        error = get_validation_errors(response, "")
+
+        self.assertIn(


Suggested change

self.assertIn(

self.assertEqual(

…istry from commonground-api-common

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch from f19beff to 9f8bbc0 Compare January 27, 2026 11:59

OlhaZahoruiko marked this pull request as ready for review January 27, 2026 11:59

OlhaZahoruiko requested review from danielmursa-dev and stevenbal January 27, 2026 12:00

OlhaZahoruiko mentioned this pull request Jan 27, 2026

✨ [#142] Allow registering custom exception handlers in exce… maykinmedia/commonground-api-common#145

Merged

danielmursa-dev reviewed Jan 30, 2026

View reviewed changes

OlhaZahoruiko requested a review from danielmursa-dev February 3, 2026 08:59

stevenbal mentioned this pull request Feb 6, 2026

Allow defining a mapping of exceptions to responses for exception_handler maykinmedia/commonground-api-common#142

Open

stevenbal requested changes Feb 10, 2026

View reviewed changes

requirements/base.in Outdated Show resolved Hide resolved

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch from 5ee4377 to 0dd574b Compare February 10, 2026 11:55

OlhaZahoruiko requested a review from stevenbal February 10, 2026 11:56

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch 2 times, most recently from 6de9948 to d42b42e Compare February 10, 2026 14:21

stevenbal requested changes Feb 10, 2026

View reviewed changes

danielmursa-dev reviewed Feb 11, 2026

View reviewed changes

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch from f26f6b6 to 178c973 Compare February 12, 2026 11:08

OlhaZahoruiko requested review from danielmursa-dev and stevenbal February 12, 2026 11:18

danielmursa-dev reviewed Feb 12, 2026

View reviewed changes

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch from 178c973 to ff73c5f Compare February 12, 2026 13:42

OlhaZahoruiko requested a review from danielmursa-dev February 12, 2026 13:52

danielmursa-dev reviewed Feb 12, 2026

View reviewed changes

danielmursa-dev approved these changes Feb 12, 2026

View reviewed changes

✨ [maykinmedia/commonground-api-common#142] Use exception handler reg…

270fa43

…istry from commonground-api-common

OlhaZahoruiko force-pushed the feature/142-custom-exception-handlers branch from ff73c5f to 270fa43 Compare February 12, 2026 14:09

stevenbal approved these changes Feb 12, 2026

View reviewed changes

stevenbal merged commit 840e819 into master Feb 12, 2026
27 checks passed

stevenbal deleted the feature/142-custom-exception-handlers branch February 12, 2026 15:08

		response = self.client.get(self.url, {"type": objecttype_url})

		self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)


		data = response.json()

		invalid_params = {p["name"]: p for p in data["invalid_params"]}

	invalid_params = {p["name"]: p for p in data["invalid_params"]}
	error = get_validation_errors(response, "type")

	invalid_params = {p["name"]: p["reason"] for p in data["invalid_params"]}
	error = get_validation_errors(response, "")

	reasons = [p["reason"] for p in data["invalid_params"]]
	error = get_validation_errors(response, "")

	self.assertEqual(
	error = get_validation_errors(response, "")
	self.assertEqual(error["reason"]

	data["invalid_params"][0]["reason"],
	error = get_validation_errors(response, "")
	data["invalid_params"][0]["reason"],

✨ [maykinmedia/commonground-api-common#142] Use exception handler registry from commonground-api-common #723

✨ [maykinmedia/commonground-api-common#142] Use exception handler registry from commonground-api-common #723

Uh oh!

Conversation

OlhaZahoruiko commented Jan 26, 2026

Uh oh!

codecov-commenter commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielmursa-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevenbal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Feb 10, 2026 •

edited

Loading